[7096][ADD] report_positioned_image, report_qweb_element_page_visibility - #35
Merged
Conversation
yostashiro
changed the title
Not yet on the upstream 19.0 branch, so it cannot be aggregated; ocj vendors OCA code into ocj-oca rather than aggregating upstream repositories. Vendored from OCA/reporting-engine@30d0138 (refs/pull/1193/head) Assisted-by: Claude Opus 5
Dependency of report_positioned_image, which cannot install without it: it is not reachable from this project's addons path, since ocj aggregates no upstream OCA repositories. Unlike report_positioned_image this module is already on the upstream branch, so the copy is redundant with upstream and can be retired if reporting-engine is ever aggregated directly. Vendored from OCA/reporting-engine@b730d60 (19.0) Assisted-by: Claude Opus 5
yostashiro
force-pushed
the
19.0-add-report_positioned_image
branch
from
August 28, 2026 10:48
55c3e4d to
bbe7035
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vendors two OCA modules from
OCA/reporting-engine:report_positioned_image19.0)30d0138report_qweb_element_page_visibility19.0branchb730d60The second is a dependency of the first and is not otherwise reachable from this project's addons path, since ocj aggregates no upstream OCA repositories. It is already on the upstream
19.0branch, so that copy is redundant with upstream and can be retired ifreporting-engineis ever aggregated directly.Each module's origin is recorded as a
Vendored from <repo>@<sha> (<ref>)line in its vendoring commit, so a later re-sync can tell which upstream commit the copy is — which matters most forreport_positioned_image, whose source is a PR head that can move or be closed.QT7096
Assisted-by: Claude Opus 5