Skip to content

cv_1st - #13

Open
marianabagulho wants to merge 1 commit into
qpit:submissionsfrom
marianabagulho:tutorial
Open

cv_1st#13
marianabagulho wants to merge 1 commit into
qpit:submissionsfrom
marianabagulho:tutorial

Conversation

@marianabagulho

Copy link
Copy Markdown

Tutorial 1st

@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@yamoceans

Copy link
Copy Markdown

It does not appear to be fully done, but for a first draft I would say it is pretty good. It mentions important concepts for understanding continuous variables, but I do think that you can expand further on the wigner function. I would say you should probably show the Wigner function's expression and its variants for the ones you plot. You could perhaps also expand more on the dynamics we are seeing in the figures.
Also the code in the first figure raised an error since the variable "colors" is not defined.

@InesC2478

Copy link
Copy Markdown

The basics are well expained and clear and the plots are revelevant and well done, simple and easy to understand, labeled correctly and color coded.
However, a further mathematical explanation on the types of states like the coherent state could be added, as well as a description and even plot for squeezed states.
For better understanding, a mathematical comparison between the differences for discreet and continuous states could be used in the introduction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants