Fix/review issues utf8 deps params#1
Open
qingyabailu-git wants to merge 2 commits into
Open
Conversation
- 移除 skills/fiction-write/SKILL.md 第 302-304 行的编码错误注释 - 移除 skills/fiction-doctor/SKILL.md 第 102-104 行的编码错误注释 - 移除 skills/fiction-review/SKILL.md 第 89-91 行的编码错误注释 - 移除 skills/fiction-import/SKILL.md 第 100-102 行的编码错误注释 - 移除 skills/fiction/SKILL.md 第 65-67 行的编码错误注释 - 所有文件统一为 UTF-8 无 BOM 编码 fixes: UTF-8 合法性检查问题
**README.md 改进:** - 添加 scripts/ 依赖说明,强调安装时必须同时复制 skills/ 和 scripts/ - 修改安装命令,包含 scripts/ 复制步骤 - 标记 Python 3.8+ 为必需(而非可选) **scripts/fiction.py 改进:** - 修复 `where` 命令的副作用问题:仅读取项目,找不到时返回错误退出码而非创建项目 - 新增 `setup` 命令:明确初始化项目的功能,接收 --title/--author/--genre 参数 - 修复 `review-pipeline` 命令: - 必须读取 --review-results JSON 文件 - 处理 blocking 和 suggestions 数据 - 生成实际的审查报告内容(而非只是模板) - 支持 --save-metrics 标志写入 metrics.json - 改进 `project-status` 命令:显示 author 字段 关联问题: - 解决"where 命令有副作用"问题 - 解决"review-pipeline 接收参数但不使用"问题 - 改进项目依赖透明度
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chatgpt查出来的问题;giuhub的copilot修的