Fix clippy chunks_exact_to_as_chunks warnings on stable Rust 1.98 - #171
Merged
Conversation
Replace chunks_exact with as_chunks in dataset binary readers for cleaner byte-to-scalar conversion.
qdrant-cloud-bot
force-pushed
the
fix/clippy-chunks-exact-warnings
branch
from
August 26, 2026 13:49
dda1c12 to
dacf1a8
Compare
xzfc
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cargo clippy --all-targets --all-featureswith stable Rust 1.98.0 on latestdevclippy::chunks_exact_to_as_chunkswarnings in dataset binary readers (binary.rs,h5.rs,npy.rs) by replacingchunks_exactwithas_chunksTest plan
cargo clippy --all-targets --all-featurespasses with no warningscargo test— all 161 tests pass