feat: add support for colbert-style multivector datasets - #170
Merged
Conversation
Author
|
Clippy failures seem pre-existing? It didn't catch anything locally |
xzfc
approved these changes
Aug 26, 2026
xzfc
left a comment
Member
There was a problem hiding this comment.
Thanks.
Clippy failures seem pre-existing?
That's right.
It didn't catch anything locally
These appear in Rust 1.98 which released less than a week ago. Perhaps you want to upgrade.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for loading ColBERT-style multivectors from a dataset.
The dataset, denoted by the
multivectorformat, should encompass:vectors.npyfile containing all sub-vectors stacked togetheroffsets.npyfile containingnum_points + 1vector boundaries asint32/int64We parse both files and load the
i-th vector asvectors[offsets[i]:offsets[i+1]].Here is an example configuration:
All Submissions:
devbranch. Did you create your branch fromdev?New Feature Submissions:
cargo +nightly fmt --allcommand prior to submission?cargo clippy --all --all-featurescommand?Changes to Core Features: