fix: relax urllib3 upper bound to <3.0.0 in API clients#483
Merged
Conversation
The previous constraint `urllib3 >= 2.5.0, < 2.7.0` caused a dependency conflict when projects pulled in urllib3 2.7.0 (e.g. via requests 2.33.0 which itself allows urllib3 < 3). Relax the cap to <3.0.0, matching the convention used by requests, and bump qase-api-client to 2.0.8 and qase-api-v2-client to 2.0.7. Fixes #482
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
urllib3upper bound in both API clients from< 2.7.0to< 3.0.0so they can coexist with urllib3 2.7.x (and any future 2.x), matching the constraint convention used byrequests.qase-api-clientto 2.0.8 andqase-api-v2-clientto 2.0.7.The previous cap caused a pip resolver conflict reported in #482: projects depending on both
qase-api-client==2.0.7andurllib3==2.7.0(transitively required byrequests 2.33.0) failed to install.Fixes #482
Test plan
qase-api-client==2.0.8andqase-api-v2-client==2.0.7in a fresh env together withrequests==2.33.0andurllib3==2.7.0— resolver succeeds.