Skip to content

Default to weights_only=True when loading pretrained weights #9632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
fjankovi wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Default to weights_only=True when loading pretrained weights #9632

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions torchvision/models/_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,13 @@ def verify(cls, obj: Any) -> Any:
return obj

def get_state_dict(self, *args: Any, **kwargs: Any) -> dict[str, Any]:
# Load checkpoints with ``weights_only=True`` by default so a tampered
# checkpoint cannot execute arbitrary code via pickle during unpickling.
# ``torch.hub.load_state_dict_from_url`` forwards ``weights_only`` to
# ``torch.load`` explicitly, so it does not benefit from the
# ``weights_only=True`` default that ``torch.load`` itself adopted in
# PyTorch 2.6 -- it must be requested here. Callers may still override.
kwargs.setdefault("weights_only", True)
return load_state_dict_from_url(self.url, *args, **kwargs)

def __repr__(self) -> str:
Expand Down