[Bug] Handle uppercase L40S device names - #4299
Merged
tianyu-l merged 1 commit intoAug 24, 2026
Merged
Conversation
taking-lying-flat
requested review from
fegin,
tianyu-l,
wconstab and
wwwjn
as code owners
August 23, 2026 09:19
meta-cla
Bot
added
the
CLA Signed
tianyu-l
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make the L40S peak-FLOPS check case-insensitive by matching against
device_name.casefold().Why
get_peak_flops()currently searches for the lowercase substringl40sin the original device name. CUDA commonly reports this accelerator asNVIDIA L40S, so the case-sensitive check misses it and falls through to the unknown-GPU A100 fallback.That fallback reports 312 BF16 TFLOPS instead of the configured L40S value of 362 BF16 TFLOPS. Since peak FLOPS is the denominator of MFU, this causes L40S utilization metrics to be calculated against the wrong hardware limit and appear artificially high.
Using
casefold()only at the L40S comparison accepts both common uppercase names and lowercase variants without changing any other device-detection branch.