Implement JSON output for external consumers and update workflow#2079
Conversation
Added functionality to write a JSON bundle for external consumers, including schema version and generation timestamp.
✅ Deploy Preview for pytorch-dot-org-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Hi @marco-s , thank you for updats, it look good to me. Parsing a Json is very easy compared to parsing a js file :D |
|
Hi @albanD, would you mind helping to review this PR, thank you in advance. Why we need those changesThe JSON is easier to parse than JS file from WP side, so we need to save the output into JSON and release it in the master branch for website. |
|
Thanks for fixing the CI error @marco-s |
albanD
left a comment
albanD
left a comment
There was a problem hiding this comment.
Outputting json sounds fair. But the workflow update needs to be inspected a lot closer.
Pin action versions to commit SHA in the workflow and removed the issue creation step.
|
@fffrog @can-gaa-hou Want to tag you as well to make sure that we can continue with the review of this PR. Is there anything we need to address? Thank you for your help! |
6 participants
Description
This pull request enhances the
gen_additional_platforms.pyscript to generate a new JSON bundle for external consumers. And, it updates the workflow to install required Python dependencies, adds automated error reporting and pull request creation.Motivation
Make it easier for external consumers to get the additional platforms matrix information. This PR adds to #2072.