Rebase index_copy fix - #62
Open
wonjoo-wj wants to merge 4 commits into
Open
Conversation
|
@wonjoolee95 can you do a run and see if this change has any performance implication? |
Collaborator
Author
|
This rebase seems to give me the And when we change to We can tackle the SPMD inference work and this issue separately. For now, we can either keep using the existing out-of-place .index_copy and manually set the dynamo_cache_hit or use continuing using the 05012024 wheels. cc @bhavya01 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebase @bhavya01's index_copy fix from
llama2-google-next-inferencebranch