gh-148484: Fix memory leak of iterator in array.array constructor#148523
Open
gleb-pp wants to merge 4 commits intopython:mainfrom
Open
gh-148484: Fix memory leak of iterator in array.array constructor#148523gleb-pp wants to merge 4 commits intopython:mainfrom
gleb-pp wants to merge 4 commits intopython:mainfrom
Conversation
skirpichev
requested changes
Apr 13, 2026
Member
skirpichev
left a comment
skirpichev
left a comment
There was a problem hiding this comment.
This patch ensures that the iterator is correctly DECREF'ed on all error paths after it is created.
That's not true, you ignored some case. For example, shown in the issue thread.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix memory leak of iterator in array.array constructor
When array.array is initialized with an arbitrary iterable, a Python iterator object is created via PyObject_GetIter().
If an error occurs later in array initialization (e.g. during element insertion or sequence conversion), the iterator was not properly decref'd, leading to a memory leak.
This patch ensures that the iterator is correctly DECREF'ed on all error paths after it is created.
The issue affects the fallback iterable initialization path only. Fast-path initializers (list, tuple, bytes, bytearray, array, str) are not affected.