fix: apply additionalLabels also to podSpec#24
Closed
fstr wants to merge 3 commits into
Closed
Conversation
123BLiN
approved these changes
Jun 11, 2025
gracco
approved these changes
Jun 11, 2025
Collaborator
|
Hey, thank you for your PR. We will revisit this once the initial release using this repository is done. |
Collaborator
|
Hey, I think the chart is finally ready to go. Can you please rebase your PR as we released 0.16.0 |
Collaborator
|
@fstr are you still planning to implement this? |
|
@fstr |
idris-nintex
approved these changes
Apr 6, 2026
fstr
force-pushed
the
fstr/issue-21
branch
3 times, most recently
from
6082ff4 to
34930d1
Compare
Author
|
@sebastiangaiser @idris-nintex I just rebased the changes onto latest main. Requires a new approval. |
Signed-off-by: Florian Strübe <florian@firebolt.io>
Co-authored-by: Sebastian Gaiser <sebastiangaiser@users.noreply.github.com> Signed-off-by: Florian Strübe <florian@firebolt.io>
Co-authored-by: Sebastian Gaiser <sebastiangaiser@users.noreply.github.com> Signed-off-by: Florian Strübe <florian@firebolt.io>
sebastiangaiser
requested changes
Apr 16, 2026
Collaborator
sebastiangaiser
left a comment
sebastiangaiser
left a comment
There was a problem hiding this comment.
Can you please add a simple Helm unit-test
sebastiangaiser
added a commit
to sebastiangaiser/pyrra-dev-helm-charts
that referenced
this pull request
May 22, 2026
Mirror the existing podAnnotations value with a new podLabels knob that adds labels to spec.template.metadata.labels only. The Deployment selector (matchLabels) is intentionally left untouched to preserve Kubernetes' immutable selector contract. Closes pyrra-dev#21, supersedes pyrra-dev#24 Signed-off-by: Sebastian Gaiser <sebastiangaiser@users.noreply.github.com>
sebastiangaiser
added a commit
to sebastiangaiser/pyrra-dev-helm-charts
that referenced
this pull request
May 22, 2026
Mirror the existing podAnnotations value with a new podLabels knob that adds labels to spec.template.metadata.labels only. The Deployment selector (matchLabels) is intentionally left untouched to preserve Kubernetes' immutable selector contract. Closes pyrra-dev#21, supersedes pyrra-dev#24 Signed-off-by: Sebastian Gaiser <sebastiangaiser@users.noreply.github.com>
Collaborator
|
Closing as #111 got merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds the
additionalLabelsto the podSpec, not just the deploymentSpec. I believe that this approach is the most backwards friendly approach.I checked how other charts use it and it's really a mixed approach. Some have global "labels" and specific "podLabels". Some have "extraLabels" and apply them to all resources.
Solves #21