Implement SymbolicRVOp#2186
Draft
ricardoV94 wants to merge 2 commits into
Draft
Conversation
ricardoV94
force-pushed
the
symbolicOp_rvs
branch
from
afa50b7 to
bea3a50
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1221
We get huge speedup on batched MvNormal draws because we can split the cholesky from the random draw loop. Also fixes a bunch of cases that would fail in numba due to numba
np.dotoverload limitations that we work around in our direct dispatch ofDot.Will also help reducing Ops and supporting other backends.
This PR sets up the stage, and should be followed up by simplifications of trivial variables like
HalfNormal = abs(Normal)and the like.It may also facilitate autodiff since most natural implementations would be the "trick" ones, but that's not the motivation for this PR
Still heavily bot generated. Need to clean up. And think about inlining at some stage of the pipeline.