Fix BlockTextureEntity Brightness#797
Open
JustAHuman-xD wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #634
In order to give accurate lighting information we have to move the location of the entity to a block that has lighting data, specifically the one with the most light. of the rebar block itself is transparent then it will have lighting data (think glass) and we don't have to do anything, but if its opaque (think copper block) then we have to delegate to a neighbor that has the most light
that also means we have to watch for the neighbors changing
I removed the ability to change the transformation of the base BlockTextureEntity interface so that I can safely in the impl avoid sending unnecessary data.
In this I also fix a couple of bugs in the related systems (i.e. making a rebar block visible/culled every tick if it was within the always show radius or outside the cull radius instead of following the visible/hidden intervals)