Add plant oil furnace#763
Conversation
OhmV-IR
changed the title
LordIdra
left a comment
LordIdra
left a comment
There was a problem hiding this comment.
(Same issue for plant oil furnace)
Plant oil furnace missing recipe (should be pretty damn cheap I think to encourage using this early game)
Plant oil furnace currently has the same appearance as diesel machines which should be changed
Plant oil furnace should have drastically lower fluid consumption (5 mb/s or similar), and I think diesel furnace too tbh (10 mb/s?)
# Conflicts: # src/main/java/io/github/pylonmc/pylon/PylonItems.java # src/main/resources/lang/en.yml
OhmV-IR
force-pushed
the
fluid-furnace-refactor
branch
from
edadae5 to
0510e23
Compare
OhmV-IR
changed the title
|
letr me know when this is ready for re-review |
LordIdra
left a comment
LordIdra
left a comment
There was a problem hiding this comment.
I would much rather these two were just separate classes as this seems like overabstraction, but not going to block on that
| RebarArgument.of("speed", UnitFormat.PERCENT.format(speed * 100)), | ||
| RebarArgument.of("input-fluid", inputFluid.getName()))); | ||
| if (outputFluid != null && fluidOutputRate != null) { | ||
| args.add(RebarArgument.of("output-fluid", outputFluid.getName())); |
There was a problem hiding this comment.
I would use the uncolored name for the output fluid rate/buffer placeholders or just use 'Fluid usage' and 'Fluid buffer', it looks a bit weird considering no other attributes are ever colored
| - "CDC" | ||
| - "DDD" | ||
| - "CDC" |
There was a problem hiding this comment.
slightly unhinged recipe
I would change it to be more similar to diesel furnace recipe
| createFluidPoint(FluidPointType.INPUT, BlockFace.SOUTH); | ||
| if (outputFluid != null) { | ||
| createFluidPoint(FluidPointType.OUTPUT, BlockFace.NORTH); | ||
| } |
There was a problem hiding this comment.
fluid points need to be directional
There was a problem hiding this comment.
It would be good if the furnace was lit while it was working
| public final @Nullable RebarFluid outputFluid = getSettings().get("output-fluid", ConfigAdapter.REBAR_FLUID); | ||
| public final int inputWailaNBars = getSettings().getOrThrow("input-waila-bar-length", ConfigAdapter.INTEGER); | ||
| public final @Nullable Integer outputWailaNBars = getSettings().get("output-waila-bar-length", ConfigAdapter.INTEGER); | ||
| public final TextColor inputWailaBarColor = getSettings().getOrThrow("input-waila-bar-color", ConfigAdapter.TEXT_COLOR); |
There was a problem hiding this comment.
with the new fluid text color changes you can get the color directly from the fluid now
|
Aww man my guess was about 3 off :( |
3 participants
Refactors DieselFurnace into a general class that can take in any fluid from config and add the plant oil furnace
Closes #719
I need to test this ig