Skip to content

Rework some tests for shorter CI runs#575

Merged
yguclu merged 31 commits into
develfrom
shorter_CI
Mar 25, 2026
Merged

Rework some tests for shorter CI runs#575
yguclu merged 31 commits into
develfrom
shorter_CI

Conversation

@campospinto
Copy link
Copy Markdown
Collaborator

@campospinto campospinto commented Feb 13, 2026

  • Speed-up some tests by using coarser grids and fewer patches in multi-patch domains
  • Improve asserts in feec/tests/test_global_projectors.py by using the expected convergence orders
  • Ignore additional paths through .gitignore:
    • prof folders generated by profiling tools
    • __*pyccel__*/ folders generated by Pyccel

(Since these changes are really minor I don't think they deserve to be mentioned in the changelog)

@campospinto campospinto added performance Make the code run faster testing Unit tests, coverage, benchmarks labels Feb 13, 2026
@campospinto campospinto marked this pull request as draft February 13, 2026 14:30
@campospinto campospinto marked this pull request as ready for review February 13, 2026 14:30
@codacy-production
Copy link
Copy Markdown

codacy-production Bot commented Feb 13, 2026

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.08% 75.36%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (554017e) 49476 32941 66.58%
Head commit (46a64c7) 98940 (+49464) 65796 (+32855) 66.50% (-0.08%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#575) 276 208 75.36%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@yguclu yguclu changed the title rework some tests for shorter CI tests Rework some tests for shorter CI runs Feb 13, 2026
@campospinto campospinto marked this pull request as draft February 18, 2026 11:45
@campospinto campospinto marked this pull request as ready for review February 18, 2026 11:45
Copy link
Copy Markdown
Member

@yguclu yguclu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! It can probably be merged very soon

Comment thread psydac/api/tests/test_2d_multipatch_mapping_maxwell.py Outdated
Comment thread psydac/api/settings.py Outdated
Comment thread psydac/feec/tests/test_global_projectors.py Outdated
Comment thread psydac/feec/tests/test_global_projectors.py Outdated
Comment thread psydac/feec/tests/test_global_projectors.py Outdated
Comment thread psydac/api/tests/test_2d_multipatch_mapping_maxwell.py Outdated
@campospinto campospinto marked this pull request as draft February 26, 2026 15:02
@campospinto campospinto marked this pull request as ready for review February 26, 2026 15:02
Copy link
Copy Markdown
Member

@yguclu yguclu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR, @campospinto!

I have a few minor comments

Comment thread psydac/api/tests/build_domain.py Outdated
Comment thread psydac/api/tests/build_domain.py Outdated
Comment thread psydac/api/tests/build_domain.py Outdated
Comment thread psydac/api/tests/build_domain.py Outdated
Comment thread psydac/api/tests/build_domain.py Outdated
Comment thread psydac/api/tests/build_domain.py Outdated
Comment thread psydac/api/tests/build_domain.py Outdated
Comment thread psydac/api/tests/build_domain.py
Comment thread psydac/feec/tests/test_global_projectors.py Outdated
Comment thread psydac/feec/multipatch_domain_utilities.py Outdated
@yguclu yguclu marked this pull request as draft March 3, 2026 07:09
@yguclu yguclu marked this pull request as ready for review March 3, 2026 07:09
@yguclu yguclu marked this pull request as draft March 3, 2026 08:54
@yguclu yguclu marked this pull request as ready for review March 3, 2026 08:54
@yguclu yguclu marked this pull request as ready for review March 9, 2026 22:10
@yguclu yguclu marked this pull request as draft March 9, 2026 22:31
@yguclu yguclu marked this pull request as ready for review March 9, 2026 22:31
@yguclu yguclu marked this pull request as draft March 10, 2026 07:55
@yguclu yguclu marked this pull request as ready for review March 10, 2026 07:55
@campospinto
Copy link
Copy Markdown
Collaborator Author

I think all the requests have been addressed. I'm switching on the tests again.

@campospinto campospinto marked this pull request as draft March 13, 2026 14:41
@campospinto campospinto marked this pull request as ready for review March 13, 2026 14:41
@campospinto campospinto marked this pull request as draft March 13, 2026 16:09
@campospinto campospinto marked this pull request as ready for review March 13, 2026 16:10
@yguclu
Copy link
Copy Markdown
Member

yguclu commented Mar 25, 2026

Blocked by #579

@yguclu
Copy link
Copy Markdown
Member

yguclu commented Mar 25, 2026

Blocked by #579

Cleared after merging #579 into devel

@yguclu yguclu marked this pull request as draft March 25, 2026 14:49
@yguclu yguclu marked this pull request as ready for review March 25, 2026 14:49
@yguclu yguclu marked this pull request as draft March 25, 2026 17:25
@yguclu yguclu marked this pull request as ready for review March 25, 2026 17:25
Copy link
Copy Markdown
Member

@yguclu yguclu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the final changes! This PR looks good to me

@yguclu yguclu merged commit 1bd4101 into devel Mar 25, 2026
10 checks passed
@yguclu yguclu deleted the shorter_CI branch March 25, 2026 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

performance Make the code run faster testing Unit tests, coverage, benchmarks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants