Feat/insights user flow sankey#3
Open
poluruprvn wants to merge 13 commits into
Open
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Break back-edges before Recharts layout and stabilize node/link render props. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
# Conflicts: # src/api/genproto/dashboard/dashboards/v1/dashboards_pb.ts # src/api/genproto/public/auth/v1/auth_pb.ts # src/api/genproto/public/dashboards/v1/dashboards_pb.ts # src/api/genproto/shared/insights/v1/insights_pb.ts
Deploying pug-garib-dev with
|
| Latest commit: |
ec78890
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6d8df5b7.cotton-ui-8bk.pages.dev |
| Branch Preview URL: | https://feat-insights-user-flow-sank.cotton-ui-8bk.pages.dev |
poluruprvn
force-pushed
the
feat/insights-user-flow-sankey
branch
from
5848ff9 to
c827403
Compare
…ow-sankey # Conflicts: # src/pages/routegen/dashboards/panels/display-tab.tsx # src/pages/routegen/insights/content.tsx
…ow-sankey # Conflicts: # src/api/genproto/dashboard/dashboards/v1/dashboards_pb.ts # src/api/genproto/dashboard/projects/v1/projects_pb.ts # src/api/genproto/shared/insights/v1/insights_pb.ts # src/pages/routegen/insights/index.page.tsx
Drop the removed GROUP_BY_USER option (enum is now session-only) and derive node labels from id since UserFlowNode no longer carries a label field. The synthetic overflow bucket is rendered as 'Others' via the is_others flag rather than matching the id string.
…ow-sankey # Conflicts: # src/hooks/use-filter-query-params.ts # src/pages/routegen/dashboards/insight-tile-content.tsx # src/pages/routegen/dashboards/panels/data-tab.tsx # src/pages/routegen/dashboards/panels/insight-fields.tsx # src/pages/routegen/dashboards/query.ts # src/pages/routegen/insights/constants.ts # src/pages/routegen/insights/content.tsx # src/pages/routegen/insights/index.page.tsx
…ow-sankey Resolve conflicts where main's dashboard-tile refactor (InsightTileView + tileOptionApplicability + per-tile viz options) overlapped the user-flow Sankey insight: - insight-tile-content.tsx: adopt main's InsightTileView delegation; restore a module-level queryReady that also handles USER_FLOW (no-event specs). - insight-tile-view.tsx: thread isUserFlow + userFlowResult through to InsightsContent and treat 'userFlow' as a known result case. - content.tsx: keep both prop sets (userFlowResult + logScale/zeroBaseline/ hideLegend/yTickFormatter). - data-tab.tsx: union the insights imports (UserFlowControls + InsightsRowAggregationControls + isIncompleteNumericAggregation). - display-tab.tsx / option-applicability.ts: make the centralized view-mode gating user-flow-aware (Sankey picker).
Carry the server's depth/label through buildSankeyData and render with recharts <Sankey align="left"> so each node stays in its step column instead of being pinned to the last column (recharts' default "justify" pins terminal nodes to the right, which reintroduced spanning arcs). The graph is now a strict layered DAG, so the cycle-breaker is no longer required; it is kept as a defensive guard so a stale page-collapsed response degrades instead of crashing recharts' depth recursion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.