Skip to content

Upgrade PubNub JS SDK dependency - #416

Merged
jguz-pubnub merged 2 commits into
masterfrom
feat/pubnub-js-upgrade
Aug 12, 2026
Merged

Upgrade PubNub JS SDK dependency#416
jguz-pubnub merged 2 commits into
masterfrom
feat/pubnub-js-upgrade

Conversation

@jguz-pubnub

@jguz-pubnub jguz-pubnub commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

fix: Internal fixes

@codacy-production

codacy-production Bot commented Aug 11, 2026

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@parfeon parfeon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jguz-pubnub

Copy link
Copy Markdown
Contributor Author

@pubnub-release-bot release kotlin as v13.4.2

@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

The PR updates the PubNub JavaScript dependency to 12.0.3 and releases the Kotlin SDK as version 13.4.2 across metadata, documentation, changelogs, and tests.

Changes

PubNub JavaScript dependency update

Layer / File(s) Summary
Update PubNub JavaScript version
gradle/libs.versions.toml
The version catalog updates pubnub_js from 11.0.1 to 12.0.3.

Kotlin SDK 13.4.2 release

Layer / File(s) Summary
Update release metadata and publication references
.pubnub.yml, gradle.properties
Project version, bundled JAR, Maven package, and repository references update to version 13.4.2.
Update release documentation and version validation
CHANGELOG.md, README.md, pubnub-kotlin/pubnub-kotlin-impl/src/test/kotlin/com/pubnub/api/legacy/PubNubImplTest.kt, .pubnub.yml
The changelog, Maven example, release metadata changelog, and version assertion reference 13.4.2.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: jakub-grzesiowski, kleewho, marcin-cebo

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive The description refers to internal fixes but is too vague to clearly describe the dependency and Kotlin SDK version updates. Describe the PubNub JS SDK dependency upgrade and the Kotlin SDK 13.4.2 release changes.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the PubNub JS SDK dependency upgrade, which is a primary change in the pull request.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/pubnub-js-upgrade

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@CHANGELOG.md`:
- Around line 4-5: Update the Fixed heading in the changelog from level four to
level three, preserving the existing changelog hierarchy under the version
heading.

In `@README.md`:
- Line 23: Update the adjacent Gradle dependency example in the README from
version 10.0.0 to 13.4.2, matching the Maven example and current release.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 33c527e3-4706-44e0-9846-95d486c4cbcb

📥 Commits

Reviewing files that changed from the base of the PR and between 616f8d0 and e204ad1.

📒 Files selected for processing (5)
  • .pubnub.yml
  • CHANGELOG.md
  • README.md
  • gradle.properties
  • pubnub-kotlin/pubnub-kotlin-impl/src/test/kotlin/com/pubnub/api/legacy/PubNubImplTest.kt

@pubnub pubnub deleted a comment from coderabbitai Bot Aug 12, 2026
@pubnub pubnub deleted a comment from coderabbitai Bot Aug 12, 2026
@jguz-pubnub
jguz-pubnub merged commit 5ad1797 into master Aug 12, 2026
8 checks passed
@jguz-pubnub
jguz-pubnub deleted the feat/pubnub-js-upgrade branch August 12, 2026 10:57
@pubnub-release-bot

Copy link
Copy Markdown
Contributor

🚀 Release successfully completed 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants