Updated Libs and Fixed for current Wow version 1.15.9 (69109) - #14
Open
sam-k-taylor wants to merge 31 commits into
Open
Updated Libs and Fixed for current Wow version 1.15.9 (69109)#14sam-k-taylor wants to merge 31 commits into
sam-k-taylor wants to merge 31 commits into
Conversation
…CurrentMapOrInstaceId function
The slash-command options table was being nested into the Blizzard options tree after AddToBlizOptions() already scoped that panel to just the GUI subgroup, so the assignment was never read by anything.
sam-k-taylor
force-pushed
the
master
branch
5 times, most recently
from
August 15, 2026 11:04
f069b1e to
7322ddf
Compare
The client silently auto-rejoins the hidden sync channel from a prior session on its own before OnEnable runs, so the existing join delay never got a chance to help - we'd just adopt whatever low slot (e.g. 1) it had already grabbed ahead of General/Trade. Leave it immediately on enable so those default channels can claim their slots first, then rejoin after the delay as before. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
versionNum packs "MAJOR.MINOR.PATCH" assuming each segment is a single digit. A build with a two-digit segment (e.g. a "1.4.10"-style dev build) produces a bogus huge number that, once broadcast, permanently looks like a major update to every listener and disables comms for them - the stored value only clears when it stops being newer, which never happens with a real single-digit release. Reject implausible values on receive, and self-heal any value already poisoned in SavedVariables. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
CurseForge is where players actually get the addon; GitHub isn't a useful place to send them for an update. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
DrawMapIcons_Unsafe computed the minimap coordinates for continent-crossing transports (e.g. the Thundercaller zeppelin) using the player's current continent instead of the transport's actual continent. When the two didn't match, the resulting bogus-but-non-nil coordinates got pinned to the minimap edge permanently, so the icon never disappeared even when the transport was on the other continent. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.