Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the RSS feed generation by using the actual merge timestamp from pull request metadata instead of parsing the target date string. This is a follow-up to PR #9 which initially added the RSS feed generator.
Changes:
- Modified RSS feed to use actual PR merge timestamps instead of parsing folder date paths
- Added a new
ParseDatemethod to extract merge timestamps from markdown metadata - Extended the
Metadatastruct to include aMergedAtproperty
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/PRDigest.NET/RssFeedGenerator.cs | Removed conditional date parsing from target parameter and now uses metadata.MergedAt directly for RSS feed pubDate |
| src/PRDigest.NET/PullRequestAnalyzer.cs | Added ParseDate method to parse Japanese-formatted merge timestamps, added MergedAt property to Metadata struct, and updated GetMetadata to accept merge timestamp |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #9