Skip to content

Sig-fix no longer stops on errors. #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
daidoji wants to merge 1 commit into
base: pr-main
Choose a base branch
from
Open

Sig-fix no longer stops on errors. #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 35 additions & 11 deletions src/keria/app/cli/commands/sig-fix.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,11 +54,19 @@ def fix(tymth, tock=0.0, **opts):
caids.append(caid)

signify_group_habs = dict()
malformed_caids = set()
for caid in caids:
with existing.existingHby(name=caid, base=args.base) as hby:
for pre, hab in hby.habs.items():
if type(hab) is habbing.SignifyGroupHab:
signify_group_habs[pre] = hab.name
try:
with existing.existingHby(name=caid, base=args.base) as hby:
for pre, hab in hby.habs.items():
if type(hab) is habbing.SignifyGroupHab:
signify_group_habs[pre] = hab.name
except KeyError:
print(
f"This controller AID: {caid} is malformed in some way. Won't fix sigs."
)
malformed_caids.add(caid)
caids = [c for c in caids if c not in malformed_caids]

# create caches of existing public keys and next key digests and the associated prefixes
for caid in caids:
Expand Down Expand Up @@ -122,13 +130,20 @@ def fix(tymth, tock=0.0, **opts):
print()
smids = set()
rmids = set()
for v in hab.kever.verfers:
if v.qb64 in prefix_by_public_key:
smids.add(prefix_by_public_key[v.qb64][0].qb64)

for v in hab.kever.ndigers:
if v.qb64 in prefix_by_next_key_digest:
rmids.add(prefix_by_next_key_digest[v.qb64][0].qb64)
if hab.kever:
for v in hab.kever.verfers:
if v.qb64 in prefix_by_public_key:
smids.add(prefix_by_public_key[v.qb64][0].qb64)

for v in hab.kever.ndigers:
if v.qb64 in prefix_by_next_key_digest:
rmids.add(prefix_by_next_key_digest[v.qb64][0].qb64)
else:
print(
f"This hab {hab.name} - {pre} has no kever? Won't fix sigs"
)
malformed_caids.add(caid)
continue

print(
f"\t Proposed smids and rmids updates for {hab.name} - {pre}:"
Expand All @@ -151,3 +166,12 @@ def fix(tymth, tock=0.0, **opts):
print()
print("no updates performed, use --force to apply changes")
print()

print(
f"{len(malformed_caids)} malformed caids with issues that might not have had sig-fix applied"
)
print(malformed_caids)

print(
f"{len(set(caids) - malformed_caids)} caids that might have had sig-fix applied"
)