Add tests for #1485#1496
Open
prompt-driven-github[bot] wants to merge 2 commits into
Open
Conversation
Expand test_checkup_interactive_session.py with 14 additional cases covering ApprovedPatch coercions, seed() behaviour, present_finding() list independence, ask() queue exhaustion, approved_patches() edge cases, and InteractiveRepairSession protocol conformance. All 20 tests (6 existing + 14 new) pass with pytest. Closes #1485 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
4 tasks
Collaborator
|
/heal |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds tests based on the requirements in #1485.
Test Files
tests/test_checkup_interactive_session.pyTest Coverage
What These Tests Verify
Covers all 4 public types in
pdd/checkup_interactive_session.py:ApprovedPatch coercions:
strtarget is coerced toPathin__post_init__anchordict is copied on construction (mutation independence)seed() behaviour:
finding_idkey are imported correctlysetdefaultsemantics)present_finding() behaviour:
finding_idask() queue exhaustion:
""when answers deque is emptyapproved_patches() edge cases:
record_choice()callno_patchkind is excluded from approved patchesProtocol conformance:
FakeInteractiveSessionsatisfies theInteractiveRepairSessionstructural protocolContract Test Summary
N/A - no OpenAPI spec found (stdlib-only module)
Accessibility Audit Summary
N/A - not a web test
Manual Testing Summary
N/A - manual testing not applicable
Test Execution
Next Steps
Closes #1485
Generated by PDD agentic test workflow (18-step)