Move DNSToMap into its own package#750
Open
Mzack9999 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DNSToMap lived in the generic mapsutil package, which meant it pulled github.com/miekg/dns into maps. Since goflags imports mapsutil and almost every tool imports goflags, the whole dns record method set ended up linked into nearly every binary, even the ones that never touch DNS.
Moving DNSToMap into its own utils/maps/dnsmap package isolates the dns dependency so only code that actually converts DNS messages links it.
Measured on a tiny program that just parses flags through goflags, the dns code symbols drop from 1010 to 0 and the stripped binary goes from 7.66 MB to 6.17 MB, about 1.5 MB smaller across the board.
Callers should switch from mapsutil.DNSToMap to dnsmap.DNSToMap. There are no usages of it across the projectdiscovery repos today.