fix(feed-items): supply NVIDIA versions at the data shape the release feed consumes - #1123
Open
castrojo wants to merge 1 commit into
Open
fix(feed-items): supply NVIDIA versions at the data shape the release feed consumes#1123castrojo wants to merge 1 commit into
castrojo wants to merge 1 commit into
Conversation
… feed consumes FeedItems.tsx reads app.osInfo.majorPackages.NVIDIA from static/data/firehose-apps.json, but fetch-firehose.js only ever wrote Podman, systemd, and bootc into majorPackages — NVIDIA ships as an akmod built outside the OS image so it never shows up in the Syft SBOM scan for the OS stream itself. Reuse the companion-stream NVIDIA lookup already built for the Driver Versions page (fetch-github-driver-versions.js) so buildOsApp can resolve the matching NVIDIA driver version for the latest bluefin-stable and bluefin-lts release and add it to osInfo.majorPackages.NVIDIA. Fixes projectbluefin#1096 Signed-off-by: castrojo <castrojo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
FeedItems.tsxreadsapp.osInfo.majorPackages.NVIDIAto build the release-summary NVIDIA line, butfetch-firehose.jsonly ever populatedmajorPackageswithPodman,systemd, andbootc. NVIDIA ships as an akmod built outside the OS image, so it never appears in the Syft SBOM scan forbluefin-stable/bluefin-ltsthemselves — the accessor always returnednull.Fix
fetch-github-driver-versions.jsalready solves this exact problem for the Driver Versions page: it resolves the NVIDIA version for a release by looking it up in a companion SBOM stream (bluefin-nvidia-open-stablefor stable, the dedicated LTS NVIDIA stream with legacy fallbacks for LTS).This reuses that same logic (
buildNvidiaMapFromSbomStream,buildLtsNvidiaByTagFromSbom,resolveCompanionNvidia) insidefetch-firehose.js'sbuildOsApp, so the latestbluefin-stable/bluefin-ltsentry now gets its NVIDIA version resolved and written intoosInfo.majorPackages.NVIDIA— the exact data shapeFeedItems.tsxalready expects.Testing
node --test scripts/fetch-firehose.test.js scripts/fetch-github-driver-versions.test.js— added 3 new tests covering directpackageVersions.nvidia, the companion-lookup fallback, and an end-to-endbuildOsAppcase.npm test— full suite (488 tests) passes.npx eslint scripts/fetch-firehose.js scripts/fetch-firehose.test.js— clean.Fixes #1096
— hive: backend=copilot model=claude-sonnet-5
🐝 Hive Agent:
contributor| SHA:1249f00d