fix(pin-state): replace removed Bluefin LTS HWE workflow paths - #1121
Open
castrojo wants to merge 1 commit into
Open
fix(pin-state): replace removed Bluefin LTS HWE workflow paths#1121castrojo wants to merge 1 commit into
castrojo wants to merge 1 commit into
Conversation
bluefin-lts deleted build-regular-hwe.yml and build-dx-hwe.yml when it went all-in on the HWE/coreos-stable kernel for every build (see ublue-os/bluefin-lts#437). fetch-pin-state.js was still requesting those two removed paths, so every run 404'd and the bluefin-lts stream never appeared in stream-pins.json. Point the script at build-regular.yml, the currently active LTS build workflow that calls the shared projectbluefin/actions reusable-build.yml. That reusable workflow exposes an optional kernel_pin input (not kernel-pin), so update the extraction regex and tests to match. bluefin-lts currently passes no kernel_pin, so the stream correctly reports as floating rather than erroring. Signed-off-by: castrojo <castrojo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
scripts/fetch-pin-state.jsrequestedbuild-regular-hwe.ymlandbuild-dx-hwe.ymlfromprojectbluefin/bluefin-lts. Both paths were deleted when bluefin-lts went all-in on the HWE/coreos-stable kernel for every build variant (ublue-os/bluefin-lts#437, "This straight up removes the-hweimages and makes it so all images are now-hwe"). Every script run hit a 404 for both paths and thebluefin-ltsstream never populated instatic/data/stream-pins.json.Fix
build-regular.yml, the currently active build workflow inbluefin-lts, which calls the sharedprojectbluefin/actionsreusable-build.ymlworkflow.kernel_pin(underscore), notkernel-pin(hyphen) as the old HWE-era workflows used — updated the extraction regex and doc comments to match.fetch-pin-state.test.jsto cover the new key name and current workflow filename.static/data/stream-pins.json: thebluefin-ltsstream now correctly appears (empty/floating, sincebuild-regular.ymlcurrently passes nokernel_pin) instead of silently failing to populate at all.Verification
node --test scripts/fetch-pin-state.test.jspasses.node scripts/fetch-pin-state.jslive against the real GitHub API — no more 404s,bluefin-ltsstream correctly reports as floating.npx eslint scripts/fetch-pin-state.js scripts/fetch-pin-state.test.jsis clean.Fixes #1092.
— hive: backend=copilot model=claude-sonnet-5
🐝 Hive Agent:
contributor| SHA:2529b59b