fix(factory): use a public queue-data fallback for anonymous visitors - #1119
Open
castrojo wants to merge 1 commit into
Open
fix(factory): use a public queue-data fallback for anonymous visitors#1119castrojo wants to merge 1 commit into
castrojo wants to merge 1 commit into
Conversation
…visitors queue.projectbluefin.io/data.json returns 404, so anonymous visitors to the Hive Factory Dashboard never receive queue data when the hosted Knuckle instance requires login. Point the fallback at the queue-feed skill's canonical public mirror (https://projectbluefin.github.io/review/queue.json, documented in projectbluefin/common docs/skills/queue-feed.md). Its schema is a flat PR list rather than the hosted instance's QueueData shape, so normalize it into QueueData (no P0/P1 issue triage or victory-log data is available from this source, so those sections stay empty). Update the CSP connect-src allowlist to match. Fixes projectbluefin#1090 Signed-off-by: castrojo <castrojo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
HiveFactoryDashboard.tsxfalls back tohttps://queue.projectbluefin.io/data.jsonwhen the hosted Hive instance requires login, but that URL 404s — anonymous visitors get no queue data at all.Fix
QUEUE_URL_FALLBACKat the queue-feed skill's canonical public mirror,https://projectbluefin.github.io/review/queue.json(documented inprojectbluefin/commondocs/skills/queue-feed.md), which returns 200.QueueDatashape, so addnormalizePublicQueueFeed()to convert it and avoid crashing the dashboard on the mismatched shape. The public feed has no P0/P1 issue triage or victory-log data, so those sections stay empty when only this fallback is available (no regression — they render the same as whenqueueDataisnull).connect-srcallowlist to permithttps://projectbluefin.github.ioinstead of the deadhttps://queue.projectbluefin.ioorigin.Verification
npm run typecheck— no new errors (one pre-existing, unrelated error for a build-time generated data file).npx eslint src/components/HiveFactoryDashboard.tsx docusaurus.config.ts— no new warnings/errors.curlthatqueue.projectbluefin.io/data.jsonreturns 404 andhttps://projectbluefin.github.io/review/queue.jsonreturns 200.Fixes #1090
— hive: backend=copilot model=claude-sonnet-5
🐝 Hive Agent:
contributor| SHA:33b5b318