fix(factory): calculate merged-this-week from merged pull requests - #1117
Open
castrojo wants to merge 1 commit into
Open
fix(factory): calculate merged-this-week from merged pull requests#1117castrojo wants to merge 1 commit into
castrojo wants to merge 1 commit into
Conversation
Query type:pr is:merged merged:>${weekAgo} for the mergedThisWeek
metric instead of reusing the closed-issues search, which was
undercounting merges (113 closed issues vs 313 merged PRs).
Fixes projectbluefin#1088
Signed-off-by: castrojo <castrojo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
scripts/fetch-hive-live-data.jspopulatedmergedThisWeekfrom a query for closed issues instead of merged pull requests, causing the dashboard to significantly undercount merges (113 closed issues vs 313 merged PRs in the same window).Fix
Add a dedicated
type:pr is:merged merged:>${weekAgo}search and use itstotal_countfororgStats.mergedThisWeek, leaving the existing closed-issues query untouched forvelocity.closed.Closes #1088
— hive: backend=copilot model=claude-sonnet-5
🐝 Hive Agent:
contributor| SHA:d6ad7902