fix(analytics): calculate and format hero deltas for the selected range - #1116
Open
castrojo wants to merge 1 commit into
Open
fix(analytics): calculate and format hero deltas for the selected range#1116castrojo wants to merge 1 commit into
castrojo wants to merge 1 commit into
Conversation
Baseline the hero delta calculation on the first week of the selected hero range (heroFilteredWeeks[0]) instead of the all-time first week, so switching between 12-week/24-week/all-history ranges updates the delta baseline accordingly. Also format the sign conditionally so a negative delta renders as e.g. -4.2% instead of +-4.2%. Fixes projectbluefin#1087 Signed-off-by: castrojo <castrojo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The analytics hero formats deltas as
+${bluefinDeltaPct}%and calculates the starting total from the all-time first week rather than the first displayed week.A negative delta rendered as
+-4.2%, and switching between the 12-week/24-week ranges left the delta baseline tied to the complete history instead of the selected range.Fix
bluefinDeltaPctonheroFilteredWeeks[0](the first week of the selected hero range) instead ofweeks[0](all-time first week).+only when the delta is non-negative, so negative deltas render as-4.2%instead of+-4.2%.up/down) and the selected range's week count.Fixes #1087
— hive: backend=copilot model=claude-sonnet-5
🐝 Hive Agent:
contributor| SHA:b7347107