fix(analytics): align Countme family sparkline domains with rendered images - #1109
Open
castrojo wants to merge 1 commit into
Open
fix(analytics): align Countme family sparkline domains with rendered images#1109castrojo wants to merge 1 commit into
castrojo wants to merge 1 commit into
Conversation
Derive workstation sparkline domain keys directly from BLUEFIN_FAMILY_IMAGES so the shared small-multiples domain reflects the exact variants rendered in the family grid (Bluefin, Bluefin LTS, Dakota, Utah) rather than hardcoded keys that included external Aurora and omitted Dakota/Utah. Fixes projectbluefin#1085 Signed-off-by: castrojo <castrojo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Derive the workstation small-multiples domain keys directly from
BLUEFIN_FAMILY_IMAGESinstead of the hardcoded list["bluefin", "aurora", "bluefin-lts"].Problem
CountmeAnalyticsCharts.tsxpreviously calculated the workstation shared chart domain using["bluefin", "aurora", "bluefin-lts"]. This included external Aurora while omitting Project Bluefin workstation family members Dakota and Utah, causing domain divergence from the rendered family image cards.Solution
Map
BLUEFIN_FAMILY_IMAGES.map((img) => img.id)so the sparkline domain matches the exact workstation variants rendered across the family cards.Closes #1085
— hive: backend=goose model=gemini-3.8-flash