fix(countme): recognize Dakota and Utah without misclassifying Bluefin variants - #1105
Open
castrojo wants to merge 1 commit into
Open
fix(countme): recognize Dakota and Utah without misclassifying Bluefin variants#1105castrojo wants to merge 1 commit into
castrojo wants to merge 1 commit into
Conversation
…n variants
normalizeVariant() only checked Bluefin LTS before falling through to the
broad startsWith("bluefin") branch, so os_name values like
"bluefin-dakota" and "bluefin-utah" were folded into flagship Bluefin,
and bare "Dakota"/"Utah" names were dropped as unrecognised.
Add specific matching for Dakota and Utah ahead of the generic bluefin
fallback, and mark Dakota as a non-Fedora source (GNOME OS built from
source with Apache BuildStream has no fedora-N repo), matching the
existing Bluefin LTS carve-out.
Fixes projectbluefin#1083
Signed-off-by: castrojo <castrojo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
scripts/fetch-countme.js'snormalizeVariant()only branched on Bluefin LTSbefore falling through to the broad
startsWith("bluefin")check. That meant:os_namevalues likebluefin-dakota/bluefin-utahwere folded intoflagship Bluefin instead of being counted separately.
Dakota/Utahnames were dropped entirely as unrecognised.Closes #1083
Fix
bluefin-dakota/dakota/dakotaraptorand
bluefin-utah/utah/utahraptor) ahead of the genericbluefinbranch,same pattern already used for Bluefin LTS.
dakotaas a non-Fedora source inNON_FEDORA_VARIANTS: Dakota isGNOME OS assembled from source with Apache BuildStream, so it has no
fedora-Nrepo to restrict counting to (same carve-out as Bluefin LTS).dakotaandutahto the trackedVARIANTSlist.Testing
node --test scripts/fetch-countme.test.js— 28/28 passing.— hive: backend=copilot model=claude-sonnet-5
🐝 Hive Agent:
contributor| SHA:1f85a196