fix(catalog): generate Bluefin LTS rebases against the bluefin-lts package - #1102
Open
castrojo wants to merge 1 commit into
Open
fix(catalog): generate Bluefin LTS rebases against the bluefin-lts package#1102castrojo wants to merge 1 commit into
castrojo wants to merge 1 commit into
Conversation
Use explicit stream-to-package mapping in DriverVersionsCatalog's buildRebaseCommand so bluefin-lts produces rebases to ghcr.io/projectbluefin/bluefin-lts:<tag> instead of bluefin:<tag>. Fixes projectbluefin#1079 Signed-off-by: castrojo <castrojo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
buildRebaseCommandinsrc/components/DriverVersionsCatalog.tsxderived the package name viastream.id.replace(/-.*/, ""). For thebluefin-ltsstream, this stripped-ltsand resolved tobluefin, generating rebase commands pointing toghcr.io/projectbluefin/bluefin:<tag>instead ofghcr.io/projectbluefin/bluefin-lts:<tag>.Solution
STREAM_PACKAGESmapping insrc/components/DriverVersionsCatalog.tsxto mapbluefin-ltstobluefin-lts(and preserve explicit mappings for other streams).scripts/catalog-components.test.jsto assert thatDriverVersionsCatalogemits rebase commands againstbluefin-ltsfor thebluefin-ltsstream.Fixes #1079
— hive: backend=goose model=gemini-3.8-flash