Skip to content

Improve PAL Rev 0 Matching - #215

Merged
HeartPiece44 merged 1 commit into
projectPiki:mainfrom
JackPriceBurns:agent/improve-pal-rev-0-matching
Jul 25, 2026
Merged

Improve PAL Rev 0 Matching#215
HeartPiece44 merged 1 commit into
projectPiki:mainfrom
JackPriceBurns:agent/improve-pal-rev-0-matching

Conversation

@JackPriceBurns

Copy link
Copy Markdown
Contributor

Picked up the PAL version of this game a couple of days ago
Decided to take a crack at getting PAL Rev 0 to 100% matched, managed to get 1 TU away!
Last remaining is src/jaudio/syncstream.c I was able to get syncstream to match but it looked pretty fake so I didn't include

Let me know if I need to make any code style changes or move that GX_TRIANGLE_PERF_REG helper somewhere else

used a combination of Sol and Fable to help with this

@decomp-dev

decomp-dev Bot commented Jul 25, 2026

Copy link
Copy Markdown

Report for DPIJ01_PIKIDEMO (8407c6f - 735aae3)

No changes

Report for GPIE01_01 (8407c6f - 735aae3)

No changes

Report for GPIE01_00 (8407c6f - 735aae3)

No changes

Report for GPIJ01_01 (8407c6f - 735aae3)

No changes

Report for GPIJ01_02 (8407c6f - 735aae3)

No changes

Report for G98P01_PIKIDEMO (8407c6f - 735aae3)

📈 Matched code: 99.72% (+0.15%, +3388 bytes)
📈 Matched data: 95.70% (+0.01%, +240 bytes)

✅ 3 new matches
Unit Item Bytes Before After
main/card/CARDMount DoMount +170 85.72% 100.00%
main/gx/GXPerf GXSetGPMetric +90 95.93% 100.00%
main/gx/GXPerf .data +88 63.56% 100.00%

Report for GPIP01_00 (8407c6f - 735aae3)

📈 Matched code: 99.90% (+0.52%, +11572 bytes)
📈 Linked code: 99.67% (+1.98%, +43960 bytes)
📈 Matched data: 68.40% (+0.01%, +256 bytes)
📈 Linked data: 92.60% (+11.70%, +217980 bytes)

✅ 11 new matches
Unit Item Bytes Before After
main/vi/vi VIInit +991 13.42% 100.00%
main/vi/vi VIConfigure +194 90.07% 100.00%
main/card/CARDMount DoMount +170 85.72% 100.00%
main/gx/GXPerf GXSetGPMetric +90 95.93% 100.00%
main/gx/GXPerf .data +88 63.56% 100.00%
main/jaudio/syncstream __DecodePCM(StreamCtrl_*) +21 86.35% 100.00%
main/plugPikiColin/memoryCard MemoryCard::checkUseFile() +21 93.56% 100.00%
main/plugPikiYamashita/TAIbeatle TAIAflickingAfterMotionLoopBeatle::act(Teki&) +20 99.13% 100.00%
main/jaudio/osdsp_task .sbss +4 80.00% 100.00%
main/jaudio/osdsp_task __DSPHandler +4 99.59% 100.00%
main/plugPikiColin/game OnePlayerSection::init() +1 99.94% 100.00%
📈 1 improvement in an unmatched item
Unit Item Bytes Before After
main/plugPikiColin/memoryCard .sdata +1 90.55% 92.04%

Report for G98E01_PIKIDEMO (8407c6f - 735aae3)

No changes

@HeartPiece44 HeartPiece44 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, what an awesome surprise - this looks great honestly. I'm not sure there's too much of a better place for the GX macro, seems fine where it is for now since it's GXPerf-specific. Great work, thanks for fixing so much stuff for PAL!

@HeartPiece44
HeartPiece44 merged commit 9227063 into projectPiki:main Jul 25, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants