Improve PAL Rev 0 Matching - #215
Merged
HeartPiece44 merged 1 commit intoJul 25, 2026
Merged
Conversation
Report for DPIJ01_PIKIDEMO (8407c6f - 735aae3)No changesReport for GPIE01_01 (8407c6f - 735aae3)No changesReport for GPIE01_00 (8407c6f - 735aae3)No changesReport for GPIJ01_01 (8407c6f - 735aae3)No changesReport for GPIJ01_02 (8407c6f - 735aae3)No changesReport for G98P01_PIKIDEMO (8407c6f - 735aae3)📈 Matched code: 99.72% (+0.15%, +3388 bytes) ✅ 3 new matches
Report for GPIP01_00 (8407c6f - 735aae3)📈 Matched code: 99.90% (+0.52%, +11572 bytes) ✅ 11 new matches
📈 1 improvement in an unmatched item
Report for G98E01_PIKIDEMO (8407c6f - 735aae3)No changes |
HeartPiece44
approved these changes
Jul 25, 2026
HeartPiece44
left a comment
Member
There was a problem hiding this comment.
Sweet, what an awesome surprise - this looks great honestly. I'm not sure there's too much of a better place for the GX macro, seems fine where it is for now since it's GXPerf-specific. Great work, thanks for fixing so much stuff for PAL!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picked up the PAL version of this game a couple of days ago
Decided to take a crack at getting PAL Rev 0 to 100% matched, managed to get 1 TU away!
Last remaining is
src/jaudio/syncstream.cI was able to get syncstream to match but it looked pretty fake so I didn't includeLet me know if I need to make any code style changes or move that
GX_TRIANGLE_PERF_REGhelper somewhere else