Skip to content

fix(dns): validate googledns delete record ids #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sevencat2004 wants to merge 2 commits into
base: master
Choose a base branch
from
+9 −3
Open

fix(dns): validate googledns delete record ids #481

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe15621
fix(dns): validate googledns delete record ids
sevencat2004 May 30, 2026
0a5ca32
fix(dns): preserve googledns file encoding
sevencat2004 May 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions packages/dns/googledns/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,14 +123,20 @@ export default defineDns<Config>({
const token = await getAccessToken();
const project = config.projectId ?? _secret('GOOGLE_PROJECT_ID');
if (!project) throw new Error('GOOGLE_PROJECT_ID not set');
const [type, name] = recordId.split('/');
const separatorIndex = recordId.indexOf('/');
if (separatorIndex <= 0 || separatorIndex === recordId.length - 1) {
throw new Error(`Google Cloud DNS deleteRecord: invalid record id "${recordId}"`);
}
const type = recordId.slice(0, separatorIndex);
const name = recordId.slice(separatorIndex + 1);
// Need to fetch the rrset to get current rrdatas for the deletion entry.
const existing = (await this.listRecords(zoneId, config)).filter(
r => r.type === type && (r.name === name || r.name === name.replace(/\.$/, '')),
);
if (existing.length === 0) return;
const firstRecord = existing[0];
if (!firstRecord) return;
const fqdn = name.endsWith('.') ? name : `${name}.`;
const ttl = existing[0].ttl;
const ttl = firstRecord.ttl;
const res = await fetch(`${API}/projects/${project}/managedZones/${zoneId}/changes`, {
method: 'POST',
headers: { Authorization: `Bearer ${token}`, 'Content-Type': 'application/json' },
Expand Down