feat(targets): add pkg-chocolatey target (Chocolatey Community Repository)

[Alexander-Sorrell-IT]

Add pkg-chocolatey target — Chocolatey Community Repository

Implements the pkg-chocolatey distribution target (Windows), filling the README "Package managers → Chocolatey" entry. Mirrors the existing pkg-winget adapter convention.

What's included

• packages/targets/pkg-chocolatey/ — adapter, tests, package.json, tsconfig, README.
• build() generates a real .nuspec + tools/chocolateyinstall.ps1 (exe/msi/zip installer types), with XML escaping and checksum-verified install scripts.
• ship() is dry-run-safe (no network/secrets in dryRun) and surfaces the exact choco pack / choco apikey / choco push commands; live path requires CHOCOLATEY_API_KEY + the choco CLI on Windows.
• Registered pkg-chocolatey in packages/cli/src/adapter-registry.ts; TARGETS.md row added (✅).
• manualSetup notes the community moderation + VirusTotal review gate.

Tests

• smokeTest + nuspec/install-script generation (exe + zip), XML escaping, and dry-run command surfacing.
• pnpm --filter @profullstack/sh1pt-target-pkg-chocolatey typecheck and the package tests pass; pnpm install --frozen-lockfile is green.

No external CLI or secrets needed for build/test (dry-run only).

[greptile-apps]

Greptile Summary

This PR adds a pkg-chocolatey target adapter for publishing packages to the Chocolatey Community Repository, following the existing pkg-winget adapter pattern. All three issues from the prior review round (false-success live ship(), unused version parameter in renderInstallScript, and missing PowerShell single-quote escaping) have been addressed with the psEscape helper, an explicit throw, and corresponding tests.

• packages/targets/pkg-chocolatey/src/index.ts — generates .nuspec (with xmlEscape) and chocolateyinstall.ps1 (with psEscape), supports exe/msi/zip installer types, and throws clearly for the unimplemented live-publish path.
• Five targeted tests cover exe generation, zip generation, XML escaping, PS quote escaping, and the live-throw guard, alongside the standard smokeTest.
• adapter-registry.ts and TARGETS.md are updated to register the new target.

Confidence Score: 5/5

Safe to merge — the adapter is a well-scoped addition with no side effects outside its own package directory; the live publish path is intentionally unimplemented and guarded by an explicit throw.

The three issues flagged in the prior review round have all been resolved: the false-success live-ship path now throws, the unused parameter has been removed, and PowerShell single-quote escaping is implemented and tested. XML escaping for the nuspec is correct. No pre-existing code paths are modified beyond the single-line adapter registry update.

No files require special attention. The status() stub always returning 'in-review' is a known limitation consistent with the unimplemented live-publish path.

Important Files Changed

Filename	Overview
packages/targets/pkg-chocolatey/src/index.ts	Core adapter: nuspec + PS script generation with correct XML and PS escaping; ship() now throws for live path; status() is a known stub returning 'in-review'.
packages/targets/pkg-chocolatey/src/index.test.ts	Comprehensive tests covering exe/zip build, XML escape, PS quote escape, dry-run surfacing, and live-throw guard; all previous review issues are now test-covered.
packages/cli/src/adapter-registry.ts	Added 'pkg-chocolatey' in alphabetical order to the targets adapter list; no other changes.
packages/targets/pkg-chocolatey/package.json	Standard package manifest matching workspace conventions; 'main' points to src/index.ts and 'files' covers dist.
TARGETS.md	Row added for pkg-chocolatey with ✅ status; correctly positioned between pkg-scoop and pkg-apt.

Sequence Diagram

sequenceDiagram
    participant CLI
    participant Adapter as pkg-chocolatey adapter
    participant FS as Filesystem
    participant Choco as choco CLI (Windows)

    CLI->>Adapter: build(ctx, config)
    Adapter->>FS: "mkdir outDir/chocolatey/{packageId}/tools"
    Adapter->>FS: "writeFile {packageId}.nuspec (xmlEscape)"
    Adapter->>FS: writeFile tools/chocolateyinstall.ps1 (psEscape)
    Adapter-->>CLI: "{ artifact, meta: { nuspec, installScript, commands[] } }"

    CLI->>Adapter: "ship(ctx, config) [dryRun=true]"
    Adapter-->>CLI: "{ id: 'dry-run', meta: { commands[] } }"

    CLI->>Adapter: "ship(ctx, config) [dryRun=false]"
    Adapter-->>CLI: throws Error('not implemented yet')

    Note over Choco: Future live path
    Note over Choco: choco pack + choco push
    Note over Choco: requires CHOCOLATEY_API_KEY

Loading

_{Reviews (2): Last reviewed commit: "fix(pkg-chocolatey): address Greptile re..." | Re-trigger Greptile}

[Alexander-Sorrell-IT]

Thanks — all three addressed in the latest commit:

• P1 (live ship false success): live-mode ship() now throws not implemented instead of returning a synthetic {id,url} after the secret check. dry-run still surfaces the choco pack/push commands.
• P2 (PowerShell quoting): added psEscape() (doubles ' → '') applied to packageId/installerUrl/checksum/silentArgs; added a test with a quote in silentArgs + installerUrl.
• P2 (unused param): dropped the unused version param from renderInstallScript.