Skip to content

fix: correct tsconfig.base.json extends paths for bot packages (#452)#470

Open
nikos1005 wants to merge 1 commit into
profullstack:masterfrom
nikos1005:fix/bot-tsconfig-paths
Open

fix: correct tsconfig.base.json extends paths for bot packages (#452)#470
nikos1005 wants to merge 1 commit into
profullstack:masterfrom
nikos1005:fix/bot-tsconfig-paths

Conversation

@nikos1005
Copy link
Copy Markdown

Summary

Fixed the extends paths in bot package tsconfig files from ../../tsconfig.base.json to ../../../tsconfig.base.json.

Fixes #452

…llstack#452)

Use ../../../tsconfig.base.json instead of ../../tsconfig.base.json which incorrectly pointed to packages/tsconfig.base.json.
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 29, 2026

Greptile Summary

This PR corrects the extends paths in all five bot package tsconfig.json files. The packages live at packages/bot/{name}/, three levels deep from the repo root, so ../../tsconfig.base.json was resolving to the non-existent packages/tsconfig.base.json; the fix changes it to ../../../tsconfig.base.json, which correctly reaches the root-level base config.

  • Path fix: All five bot packages (core, discord, signal, telegram, whatsapp) now point to ../../../tsconfig.base.json, matching the actual location of tsconfig.base.json at the repository root.
  • Formatting: A missing trailing newline is also added to each file as a minor cleanup.

Confidence Score: 5/5

Safe to merge — the change is a mechanical correction of five identical misconfigured paths, all verified against the actual file tree.

Every changed file receives the same one-line fix, the target tsconfig.base.json exists at the repo root, and the old path pointed to a file that does not exist. No logic, runtime behavior, or other configuration is touched.

No files require special attention.

Important Files Changed

Filename Overview
packages/bot/core/tsconfig.json Fixes extends path from ../../tsconfig.base.json to ../../../tsconfig.base.json to correctly resolve the root-level base config; also adds trailing newline.
packages/bot/discord/tsconfig.json Same extends path correction and trailing newline fix as core.
packages/bot/signal/tsconfig.json Same extends path correction and trailing newline fix as core.
packages/bot/telegram/tsconfig.json Same extends path correction and trailing newline fix as core.
packages/bot/whatsapp/tsconfig.json Same extends path correction and trailing newline fix as core.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    root["/ (repo root)\ntsconfig.base.json"]
    packages["packages/"]
    bot["packages/bot/"]
    core["packages/bot/core/\ntsconfig.json"]
    discord["packages/bot/discord/\ntsconfig.json"]
    signal["packages/bot/signal/\ntsconfig.json"]
    telegram["packages/bot/telegram/\ntsconfig.json"]
    whatsapp["packages/bot/whatsapp/\ntsconfig.json"]

    root --> packages --> bot
    bot --> core
    bot --> discord
    bot --> signal
    bot --> telegram
    bot --> whatsapp

    core -- "../../../tsconfig.base.json ✅" --> root
    discord -- "../../../tsconfig.base.json ✅" --> root
    signal -- "../../../tsconfig.base.json ✅" --> root
    telegram -- "../../../tsconfig.base.json ✅" --> root
    whatsapp -- "../../../tsconfig.base.json ✅" --> root

    old["packages/tsconfig.base.json ❌\n(does not exist)"]
    core -. "../../tsconfig.base.json (old, broken)" .-> old
Loading

Reviews (1): Last reviewed commit: "fix: correct tsconfig.base.json extends ..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

packages/bot typecheck extends missing base tsconfig

1 participant