[codex] Fire status listeners at commit point#472
Merged
proboscis merged 1 commit intoJun 12, 2026
Conversation
364ffba to
ebbb6a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
effectFireStatusChangepath intoDaemon.updateStatusafter a successful status append.LastOutput.orch sendwithout--no-enter) into the same listener fanout after its legacy append, until O6 is folded intostep()v2.Root Cause
Status-change listeners were modeled as a separate
step()effect that onlystepCapturedemitted for agent inference. Other committed monitor transitions, such as PR closed/merged and dead-session verdicts, usedupdateStatusbut never emitted that listener effect.Verification
go test -count=1 ./internal/daemon/go test ./internal/daemon/ -run 'TestStatusChangeListenersFireOnceForMonitorTransitionPaths|TestUpdateStatusSameStatusIsNoOp|TestUpdateStatusAppendEventError|TestMarkRunFeedbackSentTransitions'make lintgo build ./...Additional Check
go test ./...was run and failed outside this change:internal/monitor:TestSessionNameForProjectexpects untruncated project-name prefixes, but current output uses shortened names such asorch-myp-f9a700.test/integration:TestRunWithBuiltInAgentsfailed when opencode session creation returned HTTP 500 (UnknownError, referr_0c02feb6).Issue:
inv-fire-status-change-all