Route Model/ModelVariant through the claude adapter as --model/--effort#462
Merged
Conversation
The claude adapter dropped LaunchConfig.Model and ModelVariant on the floor, so 'orch run --agent claude --model X --model-variant Y' silently launched the profile-default model. Pass them through the way the opencode adapter does: --model verbatim, variant as claude's --effort (low|medium|high|xhigh|max). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
proboscis
force-pushed
the
fix/claude-adapter-model-effort
branch
from
fd4d642 to
841d5c2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
orch run --agent claude --model X --model-variant Ysilently launched the profile-default model:ClaudeAdapter.LaunchCommandnever readLaunchConfig.Model/ModelVariant. The only ways to pin a claude model wereclaude.extra_argsin global config or--agent custom --agent-cmd.Fix
Pass them through the way the opencode adapter does:
Model→--model(e.g.claude-fable-5),ModelVariant→--effort(claude accepts low|medium|high|xhigh|max). Flag help updated.Verification
go test ./internal/agent/green incl. newTestClaudeLaunchCommandModelAndEffortorch run --agent claude --on mac --model claude-fable-5 --model-variant xhigh(acp-k4-emit-dispatcher-migration, acp-post-decision-standdown); ps confirmedclaude --dangerously-skip-permissions --model claude-fable-5 --effort xhigh …andorch psnow displays the model column for claude runs.Note: only the worker/CLI side needs the new binary (launch command is built on the worker); already deployed on CA-20035844. zeus master can pick it up on its next routine update.
🤖 Generated with Claude Code