[codex] Revive doeff-vm test layer#473
Merged
proboscis merged 1 commit intoJun 12, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packages/doeff-vm/tests/test_pyvm.pylegacy API layer with current bridge contract tests forPyVM, low-leveldoeff_vm.WithHandler,doeff.run(...), handler installers,scheduled(...), andvm_live_counts().packages/doeff-vm/testsinto the standard pytest path viapyproject.tomltestpaths.packages/doeff-vm/src/pyvm.rsVMError/Value matches explicit so the refreshed source guard does not rely on catch-all arms.Deleted stale tests grouped by removed feature
doeff_vm.run/doeff_vm.async_run,RunResult,run_with_result,raw_store, and env/store result-shape tests.doeff_vm.state,reader,writer,scheduler,put_env,state_items,env_items,logs, andPyStoresentinel/store API tests.start_program,step_once,feed_async_result, andfeed_async_error.SpawnEffect,GatherEffect,CreatePromiseEffect, old race/promise imports) and rewrote scheduler coverage throughscheduled(Spawn/Gather).DoeffGeneratorFn,FlatMap,Discontinue, no-argDelegate, andResumeContinuationassertions that no longer describe the public API.Rewritten coverage retained
PyVM().run(...)for current@doprograms and low-level DoExpr nodes.Resume,Transfer,ResumeThrow,Pass, nestedWithHandler, andGetHandlers(k).state(),reader(), andwriter()Program -> Program installers.doeff.run(scheduled(...)).vm_live_counts()/arena_stats().Verification
uv sync --reinstall --group devpassed.PATH="$HOME/.local/bin:$PATH" make syncpassed and rebuiltpackages/doeff-vmwithmaturin develop --release.uv run python -m pytest packages/doeff-vm/tests -q->28 passed.uv run python -m pytest tests/core/test_vm_legacy_tag_parser_fail_loud.py -q->6 passed.uv run python -m pytest tests -q->880 passed, 90 skipped.uv run ruff check packages/doeff-vm/tests packages/doeff-vm/doeff_vm-> passed.cargo fmt --manifest-path packages/doeff-vm/Cargo.toml --check-> passed.PATH="$HOME/.local/bin:$PATH" semgrep --config .semgrep.yaml --baseline-commit origin/main doeff/ packages/ --error->0 findingsintroduced by this commit.Note: full
PATH="$HOME/.local/bin:$PATH" make lint-semgrepstill fails on 77 pre-existing repository findings; the baseline semgrep check above reports no new findings from this PR.Refs:
vm-pyvm-stale-test-layer