[codex] Fail loud on malformed VM legacy tags#460
Merged
proboscis merged 3 commits intoJun 12, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
vm-legacy-tag-parsers-fail-loud.The legacy VM tag fallback parser no longer converts malformed control objects into plausible values. Missing payload attributes now fail loudly with tag-specific messages:
Resume/Transfer: missingvalueDelegate/Pass: missingeffectResumeThrow/TransferThrow: missingexceptionRegression coverage now lives in
tests/core/test_vm_legacy_tag_parser_fail_loud.py, so it is covered by the repository'stests/gate. I also addeddoeff-traversebuild metadata so the full root suite can import that workspace package afteruv sync --reinstall.Root Cause
The legacy parser helpers used
getattr(...).ok().map(...).unwrap_or(...), so missing Python attributes silently becameValue::UnitorValue::String("unknown exception"). The outer match also replaced useful extraction errors with generic messages.The reported
packages/doeff-vm/tests/test_pyvm.py tests/failure reproduces in this checkout as stale package-test API/export expectations (state,run,RunResult,start_program, etc.), not as a fail-loud live-path regression. Current Python constructors indoeff/program.pyand the Rust pyclasses require the relevant payload fields, so absence of those attributes is malformed for the parser paths changed here.Validation
uv sync --reinstalluv run python -m pytest tests/core/test_vm_legacy_tag_parser_fail_loud.py -q->6 passeduv run python -m pytest tests/ -q->880 passed, 90 skipped