[codex] Clear Ruff baseline violations#446
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
ruff-clean-baselineの指示に従い、doeff/、tests/、packages/の Ruff baseline 違反を解消しました。主な変更は Ruff の自動修正、未使用 import/変数の整理、相対 import の絶対 import 化、既存挙動を変えない範囲でのcheck=False/pytest.raises(match=...)/contextlib.suppressなどの lint 対応です。公開 API の re-export は削除せず、
Name as Name形式や__init__.pyの明示 re-export として維持しています。doeff.programの VM node re-export も復元し、doeff.__init__は循環 import を避ける順序にしています。noqaの扱い挙動変更を避けるため、次のカテゴリは理由付き
noqaとして残しています。N802、A002、N812、N817、N818は既存公開名や互換 alias を維持するため。F821は削除済み API を参照する仕様・回帰テストを、その意図のまま残すため。PLR0911、PLR0912、PLR0915は lint cleanup で制御フローを変えないため。E402、I001は fixture のsys.pathセットアップや循環 import 回避のため。RUF001は traceback や UI fixture の literal glyph を保持するため。RUF012は Textual などの class-level metadata を維持するため。DTZ005、PLW0603は既存の local wall-clock や module-level state model を維持するため。差分内の新規
noqaは理由なしで残らないことも確認済みです。検証
uv run ruff check doeff/ tests/ packages/->All checks passed!uv run pytest->842 passed, 84 skipped, 54327 warningsmake lint-pyright->0 errors, 0 warnings, 0 informationspublic api imports okgit diff --check origin/main...HEAD-> clean影響
挙動変更は意図していません。変更は Ruff baseline cleanup と re-export 維持に限定しています。