chore: close the aggregate-pagination project - #30100
Merged
Merged
Conversation
Contributor
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (23)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
SevInf
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the aggregate-pagination project and removes its working artifacts. Documentation-only — no source, no tests, no behaviour.
This must merge after #30098. That PR lands the project's retro learnings into
drive/calibration/dod.mdand the upgrade-instructions skill. This project produced no long-lived documentation to migrate — the one guide it wrote was deleted on review — so the learnings are its only durable output. Merging this first deletes them.What the project delivered
.aggregate()silently ignoredtake/skip/cursor/distinct/distinctOn, reducing over every matching row and returning a confident, wrong number with no signal.groupBy()had the same defect for everything chained before it. Both are fixed, with clause position deciding meaning: before a terminal, clauses shape the rows it reduces; aftergroupBy(), they page the groups.aggregate()honours the whole chaingroupBy()carries the chain before it;GroupedCollectiongainedtake/skip/orderByto page groups, with post-group pagination requiring a priororderByat the type levelDefinition of Done
All items met, with one closed as deliberately refused:
aggregate()honourstake/skip/cursorincluding bareskip, anddistinct()/distinctOn()✅having()present ✅orderByin the type state ✅test/aggregate-pagination.test.tsfree ofit.fails✅v8.0.0-rc.5.mdcarry the user-facing notice.Spun out, not dropped
#30099 fixes enum
ORDER BY/DISTINCT ONlosing declaration order behind any derived table. Manual QA found it through the grouped path, but it is pre-existing and wider —.distinct().orderBy(enumCol)has had it sincewrapWithRowNumberDedupfirst aliased a derived table back to its base name. It ships separately, before rc.5 is cut, so no released version exposes the new route unfixed.Notes
Two findings were deliberately not ticketed, per standing direction on QA follow-ups: an empty TSDoc hover at the
never-narrowing error site (cursor()behaves identically, so it is a house-level property, not a slice regression), and the demo's namespaced contract requiringdb.orm.<ns>.<Model>where flat-namespace examples usedb.orm.<Model>.🤖 Generated with Claude Code