Conversation
pjh612
requested review from
HYEBPARK,
HyoungUkJJang,
Onigiriiiiiiii and
midasWorld
August 12, 2022 21:09
midasWorld
approved these changes
Aug 13, 2022
midasWorld
left a comment
Collaborator
There was a problem hiding this comment.
고생하셨습니다! 👍
Long.MAX_VALUE 는 조건절에서 비교연산자로 쓰는거면 성능엔 상관 없을것 같습니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✅ 작업 단위
이전에는 id와 createdAt 둘 중 하나가 빠지면 validation 에러가 떴는데 현재는 id의 기본값설정이 되어 조금 더 유연하게 사용할 수 있습니다.(id는 모르겠고 createdAt, matchDate를 입력해 특정 시작지점부터 페이징 하겠음. -> 오늘을 기준으로, 또는 지금을 기준으로)
요청/응답 예시
http://localhost:8080/api/matches?distance=40&searchDateType=MATCH_DATE&matchDate=2022-08-12&size=2

http://localhost:8080/api/matches?size=2&distance=40&searchDateType=CREATED_AT&createdAt=2022-08-12 17:13:24

[DK-459 test: 조회 시간 타입별 페이징 추가에따른 테스트코드 변경](b2f7354)
🤔 고민 했던 부분
페이징 ID 기본값을 Long MAX로 했는데 이거 DB 조회 성능상 문제 없나요?.. 아시는분?