Tweaks#67
Open
jamsilva wants to merge 2 commits into
Open
Conversation
dannye
reviewed
Jun 5, 2026
| bank1call CheckCantUseTrainerDueToEffect | ||
| ret c | ||
| call $6968 | ||
| call Func_167e5.weird_jump |
Member
There was a problem hiding this comment.
I don't think this is a good fix.
This should be:
Suggested change
| call Func_167e5.weird_jump | |
| call LoadNonPokemonCardEffectCommands ; BUG: should be bank1call |
Author
There was a problem hiding this comment.
Oh, I see. That's actually the fix that Claude code came up with for @m1o1. I think if the bug wasn't documented this would be more prone to breakage in projects that change the code but with the comment, you expect such projects to fix it so, yeah, changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a few small tweaks: