fix(xtask): restore filter doc generation for AI repo#238
Open
leseb wants to merge 4 commits into
Open
Conversation
The migration from the praxis monorepo deleted filter_docs.rs and its
xtask wiring. Restore and adapt the doc generator for the new two-crate
layout (apis + filters), flatten doc output to docs/filters/{name}.md,
scan praxis core's payload_processing dir so OnInvalidBehavior expands,
and remove the stale json_rpc.md (filter moved to praxis core).
Signed-off-by: Sébastien Han <seb@redhat.com>
|
PR too large: 2434 lines added (limit: 750, excludes Cargo files, tests, docs, examples, and benchmarks). Please split into smaller PRs. Add |
praxis-bot
reviewed
Jul 2, 2026
praxis-bot
left a comment
praxis-bot
left a comment
Collaborator
There was a problem hiding this comment.
praxis-bot review: fix(xtask): restore filter doc generation for AI repo
Overall: Solid restoration of the filter doc generation xtask adapted for the two-crate AI layout. The core syn parsing, rendering, and lint pipeline are well-structured with good test coverage. A few items below.
| Severity | Count | Summary |
|---|---|---|
| Medium | 3 | Convention violation, missing test coverage, hardcoded special case |
Non-inline findings
None -- all findings are inline.
…/praxis-proxy/ai into leseb/fix-filters-doc-generation
aslakknutsen
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
filter_docs.rsxtask module deleted during the monorepo migration (commit 28377b0)apis+filters) with flat output todocs/filters/{name}.mdpayload_processingdir soOnInvalidBehaviorenum variants are expanded in config tablesjson_rpc.md(filter moved to praxis core)Test plan
cargo xtask generate-filter-docsdiscovers 18 filters and generates docscargo xtask lint-filter-docspasses with no driftmake buildsucceedsmake testpasses (82 tests)make lintpasses (clippy + fmt)