build(deps): Bump node from 22-slim to 26-slim - #2
Conversation
dependabot
Bot
added
dependencies
03da4bd to
e33e090
Compare
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThe Dockerfile's Stage 1 web-builder image is updated to use Node.js 26-slim instead of Node.js 22-slim for building the Vite SPA frontend assets. No other build stages or runtime configurations were modified. ChangesWeb Builder Base Image
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Dockerfile`:
- Line 9: Dockerfile's build stage uses "FROM node:26-slim" which conflicts with
CI's node-version "22" and web/package.json's `@types/node` ^22.10.2; update the
Dockerfile's web-builder base image to match the project's Node baseline (e.g.,
change FROM node:26-slim to FROM node:22-slim) or alternatively align CI and
package.json to 26—ensure the chosen Node major version is consistent across
Dockerfile (FROM), .github/workflows/ci.yml (node-version) and web/package.json
(`@types/node`) so all environments use the same Node baseline.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
|
|
||
| # ---- Stage 1: build the Vite SPA ------------------------------------------ | ||
| FROM node:22-slim AS web-builder | ||
| FROM node:26-slim AS web-builder |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== Dockerfile Node base images =="
rg -n '^\s*FROM\s+node:' Dockerfile
echo
echo "== GitHub workflows node-version settings =="
rg -n 'node-version:\s*"?[0-9]+' .github/workflows
echo
echo "== package.json engines/dev tooling hints =="
fd -a package.json | xargs -I{} sh -c 'echo "--- {}"; rg -n "\"engines\"|`@types/node`|vite|typescript" "{}" || true'Repository: prateekmulye/FinResearchAI
Length of output: 771
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== Dockerfile Node base images =="
rg -n '^\s*FROM\s+node:' Dockerfile
echo
echo "== GitHub workflows node-version settings =="
rg -n 'node-version:\s*"?[0-9]+' .github/workflows
echo
echo "== package.json engines/dev tooling hints =="
fd -a package.json | xargs -I{} sh -c 'echo "--- {}"; rg -n "\"engines\"|`@types/node`|vite|typescript" "{}" || true'Repository: prateekmulye/FinResearchAI
Length of output: 771
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== Dockerfile Node base images =="
rg -n '^\s*FROM\s+node:' Dockerfile
echo
echo "== GitHub workflows node-version settings =="
rg -n 'node-version:\s*"?[0-9]+' .github/workflows
echo
echo "== package.json engines/dev tooling hints =="
fd -a package.json | xargs -I{} sh -c 'echo "--- {}"; rg -n "\"engines\"|`@types/node`|vite|typescript" "{}" || true'Repository: prateekmulye/FinResearchAI
Length of output: 771
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== Dockerfile Node base images =="
rg -n '^\s*FROM\s+node:' Dockerfile
echo
echo "== GitHub workflows node-version settings =="
rg -n 'node-version:\s*"?[0-9]+' .github/workflows
echo
echo "== package.json engines/dev tooling hints =="
fd -a package.json | xargs -I{} sh -c 'echo "--- {}"; rg -n "\"engines\"|`@types/node`|vite|typescript" "{}" || true'Repository: prateekmulye/FinResearchAI
Length of output: 771
Unify Node version contract between Docker and CI
Dockerfile builds the web-builder stage with FROM node:26-slim, while .github/workflows/ci.yml runs the web job on Node 22 (node-version: "22"). Additionally, web/package.json pins @types/node to ^22.10.2, so CI and Docker are using different Node/type baselines—creating a real validation gap for Node-version-specific issues.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@Dockerfile` at line 9, Dockerfile's build stage uses "FROM node:26-slim"
which conflicts with CI's node-version "22" and web/package.json's `@types/node`
^22.10.2; update the Dockerfile's web-builder base image to match the project's
Node baseline (e.g., change FROM node:26-slim to FROM node:22-slim) or
alternatively align CI and package.json to 26—ensure the chosen Node major
version is consistent across Dockerfile (FROM), .github/workflows/ci.yml
(node-version) and web/package.json (`@types/node`) so all environments use the
same Node baseline.
Bumps node from 22-slim to 26-slim. --- updated-dependencies: - dependency-name: node dependency-version: 26-slim dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
e33e090 to
2206a7a
Compare
Bumps node from 22-slim to 26-slim.