Preserve worker error backtraces - #137
Merged
Merged
Conversation
Store worker failures with Debug formatting by default so captured cause chains and backtraces reach retry and dead-job metadata. Add an explicit formatter override for applications that need a different representation.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want higher recall? High effort reviews run extra passes and find more bugs. A team admin can switch effort levels in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0fee8b9. Configure here.
Route drain failures through the runtime error formatter so default Debug backtraces and custom representations are preserved consistently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Verification
Note
Low Risk
Stored error text changes from Display to Debug by default, which may alter dashboard copy but does not touch auth or persistence semantics; optional backtraces can expose sensitive stack data if enabled.
Overview
Worker failures persisted on retry and dead jobs now use each error’s
Debugstring instead ofDisplay, so types that embed backtraces (when enabled) surface that detail in stored metadata and the dashboard.Adds
RuntimeBuilder::error_formatterandRuntimeSettings::format_errorso apps can override the stored text (e.g. back toerror.to_string()). The executor and queue drain path both route failures through this helper; drain now takes runtime settings for formatting.Changelog, README (backtrace env notes and sensitivity), and integration tests cover default
Debugoutput and custom formatters on dead, retry, and drain flows.Reviewed by Cursor Bugbot for commit baa35fd. Bugbot is set up for automated code reviews on this repo. Configure here.