Add unique job deletion by ID or job value - #134
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a734f18. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Verification
Note
Medium Risk
Touches Redis job-deletion paths used for queue/schedule/retry membership, so incomplete cleanup could leave stale unique-job state. Changes are narrowly scoped and covered by new integration tests.
Overview
Adds
Storage::delete_unique_job, so callers can cancel a unique job by either itsJobIdor a typedJobvalue without manually reconstructing the deterministic ID.Introduces a shared
UniqueJobIdtrait that centralizes{job_name}/{unique_id}resolution, and wires envelope creation through it.Also hardens
delete_jobto atomically clear membership from waiting queues, the schedule set, retries, and the current processing list—including corrupt payloads—so deleted unique jobs can be safely re-enqueued from any pending state.Reviewed by Cursor Bugbot for commit a734f18. Bugbot is set up for automated code reviews on this repo. Configure here.