Skip to content

remove our workaround for mistune #794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonkeane merged 1 commit into from
Jun 24, 2026
Merged

remove our workaround for mistune #794

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ test = [
"flake8",
"httpretty",
"ipykernel",
"mistune<3.3; python_version=='3.8'", # 3.3+ uses re.Pattern[str], invalid on 3.8
"nbconvert",
"pyright",
"pytest-cov",
Expand Down
11 changes: 2 additions & 9 deletions tests/test_quickstart.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -819,20 +819,13 @@ def fake_get_data(package: str, resource: str):
# ---------------------------------------------------------------------------


# nbconvert pulls mistune>=3.3, which uses re.Pattern[str] and is broken on
# Python 3.8; skip the jupyter-based scaffolds there.
_PY38_NBCONVERT_SKIP = pytest.mark.skipif(
sys.version_info < (3, 9),
reason="nbconvert pulls mistune>=3.3 which is broken on Python 3.8",
)

BOOT_SMOKE_MATRIX = [
pytest.param("streamlit", "http", id="streamlit"),
pytest.param("shiny", "http", id="shiny"),
pytest.param("fastapi", "http", id="fastapi"),
pytest.param("api", "http", id="api"),
pytest.param("voila", "http", id="voila", marks=_PY38_NBCONVERT_SKIP),
pytest.param("notebook", "artifact", id="notebook", marks=_PY38_NBCONVERT_SKIP),
pytest.param("voila", "http", id="voila"),
pytest.param("notebook", "artifact", id="notebook"),
pytest.param("quarto", "artifact", id="quarto"),
]

Expand Down
Loading