Skip to content

Improve clarity for user when deploying a draft#682

Merged
amol- merged 2 commits into
mainfrom
draft-url-improve
Jun 12, 2025
Merged

Improve clarity for user when deploying a draft#682
amol- merged 2 commits into
mainfrom
draft-url-improve

Conversation

@amol-

@amol- amol- commented Jun 12, 2025

Copy link
Copy Markdown
Collaborator

Emitting both "Dashboard URL" and "Direct content URL" in case of drafts could be confusing for the user, as accessing the "Dashboard URL" will show the wrong content.

Intent

Improve clarity by clearly emitting a "Preview content URL" when a draft is deployed.

Normal Deploy:

Deployment completed successfully.
	 Dashboard content URL: https://SERVER/connect/#/apps/6d5bfc35-e596-40bc-a039-97cd926ea7ab/access
	 Direct content URL: https://SERVER/content/6d5bfc35-e596-40bc-a039-97cd926ea7ab/

Draft Deploy:

Deployment completed successfully.
	 Preview content URL: https://SERVER/preview/6d5bfc35-e596-40bc-a039-97cd926ea7ab/278869

Type of Change

  • Tweak

Approach

When --draft is used we don't output the "Dashboard URL" anymore

Automated Tests

The existing test_deploy_draft test has been updated to verify the output.

@github-actions

github-actions Bot commented Jun 12, 2025

Copy link
Copy Markdown
PR Preview Action v1.6.1
Preview removed because the pull request was closed.
2025-06-12 15:02 UTC

@github-actions

Copy link
Copy Markdown

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
5119 3981 78% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
rsconnect/api.py 77% 🟢
TOTAL 77% 🟢

updated for commit: 140ad28 by action🐍

@amol- amol- marked this pull request as ready for review June 12, 2025 13:30

@jonkeane jonkeane left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Comment thread rsconnect/api.py
Comment on lines +1142 to +1143
log_callback.info("\t Dashboard content URL: %s", app_dashboard_url)
log_callback.info("\t Direct content URL: %s", self.deployed_info["app_url"])

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to do this here, but I've always thought it was strange that rsconnect-python emits both the webapp URL as well as the standalone URL (with a name that is different from what we use elsewhere "open solo"). Maybe we should make an issue to 🚮 the standalone URL in this log? One can easily get it in the webapp (or construct it if one wanted to do that)

@amol- amol- merged commit 50e6d51 into main Jun 12, 2025
15 checks passed
@amol- amol- deleted the draft-url-improve branch June 12, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants