Skip to content

Changed percentageLabel to use time estimate, instead of percentage o…#15

Open
nickfinestead wants to merge 2 commits into
pomoke:mainfrom
nickfinestead:topbar
Open

Changed percentageLabel to use time estimate, instead of percentage o…#15
nickfinestead wants to merge 2 commits into
pomoke:mainfrom
nickfinestead:topbar

Conversation

@nickfinestead
Copy link
Copy Markdown

@nickfinestead nickfinestead commented Sep 6, 2024

I changed the formatting for the Desktop top bar label to show the formatting in "hh mm (ex. 0h 28m)". I'm currently on GNOME 46.0 and tested that this works as expected. I also added a comment to make it easier to find.

This should close #3

Please let me know if I need to change or fix anything

@nickfinestead
Copy link
Copy Markdown
Author

Something small I've noticed is that when the system is at 100% and charging there is no time estimate because result === 0 due to this._proxy.TimeToEmpty === 0 (technically because the system still is in the charging state) and this._proxy.TimeToFull === 0 so looking into a fix for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show battery time in top bar

1 participant